Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a repo list #319

Closed
wants to merge 1 commit into from
Closed

Add a repo list #319

wants to merge 1 commit into from

Conversation

daniel-hutao
Copy link
Member

@daniel-hutao daniel-hutao commented Mar 19, 2021

Signed-off-by: daniel-hutao [email protected]

I have completed a preliminary version here, welcome everyone to improve it together.

#318

Signed-off-by: daniel-hutao <[email protected]>
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: daniel-hutao
To complete the pull request process, please assign zryfish
You can assign the PR to them by writing /assign @zryfish in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 19, 2021
@LinuxSuRen
Copy link
Member

LinuxSuRen commented Mar 19, 2021

Thanks for taking the initiative. I'd prefer to have a separate file rather than put this table in a readme file.

@daniel-hutao
Copy link
Member Author

Thanks for taking the initiative. I'd prefer to have a separate file rather than put this table in a readme file.

It is appropriate to maintain these contents on a separate page, and then maintain a link in the README.md file; in addition, we need to place a list of core code repos on the official website. These things are a bit tiring for me. It is recommended to specify several internal developments who relatively more familiar with the existing code repos to do this.

@LinuxSuRen
Copy link
Member

No worries. We can take our time to do this.

Copy link
Member

@LinuxSuRen LinuxSuRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for providing the organized projects list. But I'd suggest we keep this README file clean. For example, move the projects list into a separate file.

@@ -22,3 +22,43 @@ Working Group (WG) facilitates discussions and work on cross-SIGs. For example,
- [Twitter](https://twitter.com/KubeSphere)
- [Mailing List](https://groups.google.com/forum/#!forum/kubesphere)
- [Medium (Blog)](https://itnext.io/@kubesphere)

## Repository list // WIP
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repository list // WIP

I'd like to change it to Repository list (WIP)


| | |
| ---- | ---- |
| Project | Description |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should be in line 28. And line 28 should be here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you said earlier, we hope to keep the README file clean, and we have discussed that QingCloud can assign one member who familiar with the projects list in ks org to organize the first version of the repo list, so I don’t want to summit a new commit for this issue.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, we still can merge this PR and push it forward. The most important of community is improvement instead of perfect.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will take over this PR if you're not interested in this.

@ks-ci-bot
Copy link
Collaborator

@LinuxSuRen: Closed this PR.

In response to this:

Considering this PR has not responded for a long time. I'm going to close it.

If there's anyone wants to get a list of DevOps-related repositories, please check here.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ks-ci-bot ks-ci-bot closed this Aug 16, 2021
Copy link
Member

@LinuxSuRen LinuxSuRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering this PR has not responded for a long time. I'm going to close it.

If there's anyone wants to get a list of DevOps-related repositories, please check here.

/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants