-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SRVLOGIC-474 - Add osl-operator-bundle-image #39
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've noticed so far that the other archs are missing, I still need to give a try building it on OSBS
packages/osl-operator-bundle-image/resources/logic-operator-bundle-image.yaml
Show resolved
Hide resolved
...undle-image/resources/config/manifests/bases/logic-operator-rhel8.clusterserviceversion.yaml
Show resolved
Hide resolved
@wmedvede mind reviewing please? |
- name: com.redhat.delivery.operator.bundle | ||
value: "true" | ||
- name: com.redhat.openshift.versions | ||
value: v4.12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is set this label to v4.12, but in other locations, like packages/osl-operator-bundle-image/resources/bundle/metadata/annotations.yaml it is set to v4.16.
Probably the best will be to create a new issue to check and update all com.redhat.openshift.versions
values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Ricardo Zanini <[email protected]>
Signed-off-by: Ricardo Zanini <[email protected]>
Signed-off-by: Ricardo Zanini <[email protected]>
Signed-off-by: Ricardo Zanini <[email protected]>
Signed-off-by: Ricardo Zanini <[email protected]>
1abb25e
to
78db00d
Compare
@rgdoliveira @jakubschwan can you take a second look please? |
I noticed the changes applied before in files
related to the arches were removed, can you please add them again and also apply them to generated files? Related to I'm going to try a build in OSBS now |
Signed-off-by: Ricardo Zanini <[email protected]>
Co-authored-by: Roberto Oliveira <[email protected]>
@domhanak do you have the article mentioning the OCP 4.13 as the base supported version? I remember you sending the print to our channel. Can you link it here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried a build of the bundle using this PR and the build succeeded on OSBS.
All my comments were addressed on the PR so I'm approving it. If we find something later, we can fix.
In this PR:
sonataflow-operator
resourcesMissing:
If you note, the configuration file holds the upstream version of images. We will change that upstream first by having a script in the operator package that replaces that information based on the images we depend on.
After that, I'll send another PR reusing this script to do the same here.
Please review it carefully.
JIRA: https://issues.redhat.com/browse/SRVLOGIC-474