Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SRVLOGIC-474 - Add osl-operator-bundle-image #39

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

ricardozanini
Copy link

@ricardozanini ricardozanini commented Dec 4, 2024

In this PR:

  • We are bringing in the bundle operator image to our midstream branch
  • Reusing sonataflow-operator resources
  • Modifying the YAML files when that makes sense

Missing:

If you note, the configuration file holds the upstream version of images. We will change that upstream first by having a script in the operator package that replaces that information based on the images we depend on.

After that, I'll send another PR reusing this script to do the same here.

Please review it carefully.

JIRA: https://issues.redhat.com/browse/SRVLOGIC-474

Copy link

@rgdoliveira rgdoliveira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've noticed so far that the other archs are missing, I still need to give a try building it on OSBS

@ricardozanini
Copy link
Author

@wmedvede mind reviewing please?

- name: com.redhat.delivery.operator.bundle
value: "true"
- name: com.redhat.openshift.versions
value: v4.12

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is set this label to v4.12, but in other locations, like packages/osl-operator-bundle-image/resources/bundle/metadata/annotations.yaml it is set to v4.16.
Probably the best will be to create a new issue to check and update all com.redhat.openshift.versions values.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ricardozanini
Copy link
Author

@rgdoliveira @jakubschwan can you take a second look please?

@rgdoliveira
Copy link

I noticed the changes applied before in files

  • packages/osl-operator-bundle-image/resources/logic-operator-bundle-image.yaml
  • packages/osl-operator-bundle-image/resources/content_sets.yaml

related to the arches were removed, can you please add them again and also apply them to generated files?

Related to - name: com.redhat.openshift.versions I think this is the lowest version of OCP we support, isn't it? In that case is 4.16 the oldest version we support?

I'm going to try a build in OSBS now

Co-authored-by: Roberto Oliveira <[email protected]>
@ricardozanini
Copy link
Author

ricardozanini commented Dec 12, 2024

@domhanak do you have the article mentioning the OCP 4.13 as the base supported version? I remember you sending the print to our channel. Can you link it here?

Copy link

@rgdoliveira rgdoliveira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried a build of the bundle using this PR and the build succeeded on OSBS.

All my comments were addressed on the PR so I'm approving it. If we find something later, we can fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants