Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: getNodeIP logic for no-network mode #413

Merged
merged 3 commits into from
Nov 14, 2024
Merged

fix: getNodeIP logic for no-network mode #413

merged 3 commits into from
Nov 14, 2024

Conversation

mridulgain
Copy link
Contributor

@mridulgain mridulgain commented Nov 13, 2024 •
edited
Loading

Description

Fixes #

  • in no-net mode getNodeIP shouldn't depend on kubeslice.io/node-type=gateway label
  • for slicegw-edge only use the kubeslice gateway, not the ones set up by envoy etc.

How Has This Been Tested?

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have ran go fmt
  • I have updated the helm chart as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit test cases.
  • I have verified the E2E test cases with new code changes.
  • I have added all the required E2E test cases.

Does this PR introduce a breaking change?

@mridulgain mridulgain self-assigned this Nov 13, 2024
gourishkb
gourishkb reviewed Nov 13, 2024
View reviewed changes
pkg/cluster/node.go Outdated Show resolved Hide resolved
@mridulgain
address review comments
27b8aa4 
Signed-off-by: Mridul Gain <[email protected]>
@mridulgain mridulgain changed the title fix: getNodeIp logic for no-network mode fix: getNodeIP logic for no-network mode Nov 13, 2024
@mridulgain mridulgain merged commit 2fd8592 into master Nov 14, 2024
11 checks passed
@mridulgain mridulgain deleted the fix-getNodeIp branch November 14, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gourishkb gourishkb gourishkb approved these changes

@bharath-avesha bharath-avesha bharath-avesha approved these changes

@narmidm narmidm Awaiting requested review from narmidm narmidm is a code owner

@richiesebastian richiesebastian Awaiting requested review from richiesebastian richiesebastian is a code owner

@Rahul-D78 Rahul-D78 Awaiting requested review from Rahul-D78 Rahul-D78 is a code owner

Assignees

@mridulgain mridulgain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mridulgain @bharath-avesha @gourishkb @KRANTHI0918