Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(): reconcile gateway sidecar image pull policy #411

Merged
merged 1 commit into from
Nov 8, 2024
Merged

fix(): reconcile gateway sidecar image pull policy #411

merged 1 commit into from
Nov 8, 2024

Conversation

mridulgain
Copy link
Contributor

@mridulgain mridulgain commented Nov 7, 2024 •
edited
Loading

Description

Fixes #
update gateway deployment if gateway sidecar image pull policy is changed in kubeslice-operator's env vars

How Has This Been Tested?

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have ran go fmt
  • I have updated the helm chart as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit test cases.
  • I have verified the E2E test cases with new code changes.
  • I have added all the required E2E test cases.

Does this PR introduce a breaking change?

@mridulgain mridulgain self-assigned this Nov 7, 2024
@mridulgain mridulgain merged commit 21a7556 into master Nov 8, 2024
10 of 11 checks passed
@mridulgain mridulgain deleted the fix-gw-reconciler branch November 8, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srinivas-avesha srinivas-avesha srinivas-avesha approved these changes

@narmidm narmidm Awaiting requested review from narmidm narmidm is a code owner

@bharath-avesha bharath-avesha Awaiting requested review from bharath-avesha bharath-avesha is a code owner

@richiesebastian richiesebastian Awaiting requested review from richiesebastian richiesebastian is a code owner

@Rahul-D78 Rahul-D78 Awaiting requested review from Rahul-D78 Rahul-D78 is a code owner

@gourishkb gourishkb Awaiting requested review from gourishkb gourishkb is a code owner

Assignees

@mridulgain mridulgain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mridulgain @srinivas-avesha