fix(): update gw deploy if gateway sidecar image changed #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…worker env vars Signed-off-by: Mridul Gain <[email protected]>
mridulgain
requested review from
narmidm,
bharath-avesha,
richiesebastian,
Rahul-D78 and
gourishkb
as code owners
narmidm
approved these changes
Nov 5, 2024
|
LGTM! Any test case changes required? |
1 similar comment
|
LGTM! Any test case changes required? |
Signed-off-by: Mridul Gain <[email protected]>
No. But it needed an empty string check. Thanks! |
Signed-off-by: Mridul Gain <[email protected]>
| @@ -53,6 +53,10 @@ import ( | |||
| webhook "github.com/kubeslice/worker-operator/pkg/webhook/pod" | |||
| ) | |||
|
|
|||
| const ( | |||
| DEFAULT_SIDECAR_IMG = "nexus.dev.aveshalabs.io/kubeslice/gw-sidecar:1.0.0" | |||
There was a problem hiding this comment.
Plz change this to the new 1.0.1 image.. i doubt the nexus repo is operational.
| @@ -1386,6 +1395,27 @@ func (r *SliceGwReconciler) ReconcileGatewayDeployments(ctx context.Context, sli | |||
| return ctrl.Result{}, err, true | |||
| } | |||
| return ctrl.Result{Requeue: true}, nil, true | |||
| } else { | |||
| // update logic for gateways | |||
| for i := range deployments.Items { | |||
There was a problem hiding this comment.
The "if" conditional above goes over the list of deployments indirectly through the numGwInstances, so it is not appropriate to loop over the deployments afresh in the "else" block. Please move the image check outside the numGwInstances "for" loop. Create a new loop that goes over each deployment and update if there is an image mismatch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: update if gateway sidecar image has been changed in worker-operator env vars
How Has This Been Tested?
Checklist:
go fmtDoes this PR introduce a breaking change?