Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(): configurable ns exclusion list #408

Merged
merged 2 commits into from
Oct 30, 2024
Merged

fix(): configurable ns exclusion list #408

merged 2 commits into from
Oct 30, 2024

Conversation

priyank-upadhyay
Copy link
Member

Description

This provides a configurable way to provide a list of namespaces to be excluded in namespace reconcilers. It can be passed through an environment variable. If not provided a default list would be used.

Fixes #

How Has This Been Tested?

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have ran go fmt
  • I have updated the helm chart as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit test cases.
  • I have verified the E2E test cases with new code changes.
  • I have added all the required E2E test cases.

Does this PR introduce a breaking change?

@narmidm narmidm enabled auto-merge October 29, 2024 13:26
@narmidm narmidm disabled auto-merge October 29, 2024 13:26
@priyank-upadhyay
fix(): refactors
357b4e8 
Signed-off-by: Priyank Upadhyay <[email protected]>
@priyank-upadhyay priyank-upadhyay merged commit 0bb59aa into master Oct 30, 2024
9 of 11 checks passed
@priyank-upadhyay priyank-upadhyay deleted the fix-ns-exclusion-list branch October 30, 2024 06:01
gourishkb pushed a commit that referenced this pull request Nov 18, 2024
@priyank-upadhyay @gourishkb
fix(): configurable ns exclusion list (#408)
fbf2dec 
* fix(): configurable ns exclusion list

Signed-off-by: Priyank Upadhyay <[email protected]>

* fix(): refactors

Signed-off-by: Priyank Upadhyay <[email protected]>

---------

Signed-off-by: Priyank Upadhyay <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharath-avesha bharath-avesha bharath-avesha approved these changes

@narmidm narmidm narmidm approved these changes

@richiesebastian richiesebastian Awaiting requested review from richiesebastian richiesebastian is a code owner

@Rahul-D78 Rahul-D78 Awaiting requested review from Rahul-D78 Rahul-D78 is a code owner

@gourishkb gourishkb Awaiting requested review from gourishkb gourishkb is a code owner

@mridulgain mridulgain Awaiting requested review from mridulgain mridulgain is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@priyank-upadhyay @narmidm @bharath-avesha