Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(AM-13847): vpc access ns creation #393

Merged
merged 3 commits into from
Jul 8, 2024
Merged

fix(AM-13847): vpc access ns creation #393

merged 3 commits into from
Jul 8, 2024

Conversation

mridulgain
Copy link
Contributor

Description

Fixes #

How Has This Been Tested?

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have ran go fmt
  • I have updated the helm chart as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit test cases.
  • I have verified the E2E test cases with new code changes.
  • I have added all the required E2E test cases.

Does this PR introduce a breaking change?

@mridulgain
vpc access ns creation
8b4db57 
Signed-off-by: Mridul Gain <[email protected]>
@mridulgain mridulgain self-assigned this Jul 8, 2024
mridulgain added 2 commits July 8, 2024 17:03
@mridulgain
rectify client
e5aa6f2 
Signed-off-by: Mridul Gain <[email protected]>
@mridulgain
fix svcim cleanup logic
9090a0f 
Signed-off-by: Mridul Gain <[email protected]>
@mridulgain mridulgain changed the title AM-13847: vpc access ns creation fix(AM-13847): vpc access ns creation Jul 8, 2024
@mridulgain mridulgain merged commit 46da36b into master Jul 8, 2024
10 checks passed
@mridulgain mridulgain deleted the hotfix-vpc-access branch July 8, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharath-avesha bharath-avesha bharath-avesha approved these changes

@narmidm narmidm Awaiting requested review from narmidm narmidm is a code owner

@richiesebastian richiesebastian Awaiting requested review from richiesebastian richiesebastian is a code owner

@Rahul-D78 Rahul-D78 Awaiting requested review from Rahul-D78 Rahul-D78 is a code owner

@gourishkb gourishkb Awaiting requested review from gourishkb gourishkb is a code owner

Assignees

@mridulgain mridulgain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mridulgain @bharath-avesha