Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(): remove hardcoded worker installer image #383

Merged
merged 1 commit into from
May 21, 2024
Merged

fix(): remove hardcoded worker installer image #383

merged 1 commit into from
May 21, 2024

Conversation

Rahul-D78
Copy link
Contributor

Description

Fixes #

How Has This Been Tested?

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have ran go fmt
  • I have updated the helm chart as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit test cases.
  • I have verified the E2E test cases with new code changes.
  • I have added all the required E2E test cases.

Does this PR introduce a breaking change?

github-advanced-security[bot]
github-advanced-security bot found potential problems May 21, 2024
View reviewed changes
pkg/hub/controllers/cluster/vars.go Dismissed Show resolved Hide resolved
@Rahul-D78 Rahul-D78 merged commit b3c625e into master May 21, 2024
9 of 10 checks passed
@Rahul-D78 Rahul-D78 deleted the hotfix-hardcoded-img branch May 21, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narmidm narmidm narmidm approved these changes

@bharath-avesha bharath-avesha Awaiting requested review from bharath-avesha bharath-avesha is a code owner

@gourishkb gourishkb Awaiting requested review from gourishkb gourishkb is a code owner

@mridulgain mridulgain Awaiting requested review from mridulgain mridulgain is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rahul-D78 @narmidm