Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ServiceExport): Reject Conflicting Alias Names for ServiceExport object (#315) #337

Merged
merged 1 commit into from
May 17, 2024
Merged

fix(ServiceExport): Reject Conflicting Alias Names for ServiceExport object (#315) #337

merged 1 commit into from
May 17, 2024

Conversation

soharab-ic
Copy link
Contributor

@soharab-ic soharab-ic commented Feb 23, 2024 •
edited
Loading

Description

The validating webhook will validate the ServiceExport object and admission of ServiceExport objects with conflicting alias names will be rejected.

Fixes #315

How Has This Been Tested?

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have ran go fmt
  • I have updated the helm chart as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit test cases.
  • I have verified the E2E test cases with new code changes.
  • I have added all the required E2E test cases.

Does this PR introduce a breaking change?

@soharab-ic soharab-ic marked this pull request as draft February 23, 2024 14:49
@soharab-ic soharab-ic force-pushed the reject-conflicting-alias-names-for-svcex branch 2 times, most recently from 4ef0220 to 0d43b6a Compare February 26, 2024 11:04
@soharab-ic soharab-ic force-pushed the reject-conflicting-alias-names-for-svcex branch from 6243c88 to e7a4b44 Compare February 28, 2024 10:31
@soharab-ic
Copy link
Contributor Author

soharab-ic commented Feb 29, 2024 •
edited
Loading

The issue #338 impacts this PR. Hence holding this until it is resolved.

@narmidm
Copy link
Member

narmidm commented Mar 7, 2024

The issue #338 impacts this PR. Hence holding this until it is resolved.

#339
#338

the issue is closed, and fix is merged to master please proceed @soharab-ic

@narmidm
Copy link
Member

narmidm commented Mar 7, 2024

@soharab-ic, can you rebase with the latest master. it has some fixes of E2E pipeline. It will help run E2E when PR will be ready.

@soharab-ic
Copy link
Contributor Author

@soharab-ic, can you rebase with the latest master. it has some fixes of E2E pipeline. It will help run E2E when PR will be ready.

Sure @narmidm

@soharab-ic soharab-ic marked this pull request as ready for review March 12, 2024 07:03
@soharab-ic soharab-ic changed the title WIP: fix(ServiceExport): Reject Conflicting Alias Names for ServiceExport object (#315) fix(ServiceExport): Reject Conflicting Alias Names for ServiceExport object (#315) Mar 12, 2024
@soharab-ic soharab-ic force-pushed the reject-conflicting-alias-names-for-svcex branch from db725f9 to 813d609 Compare March 14, 2024 09:27
@soharab-ic
Copy link
Contributor Author

@bharath-avesha @narmidm Please review this PR.

@NishantSingh10
Copy link
Contributor

report link 'https://kubeslice.github.io/e2e-allure-reports/Kind-worker-operator-2024-03-19T05:22:38-master-442/index.html'

@soharab-ic soharab-ic force-pushed the reject-conflicting-alias-names-for-svcex branch from 813d609 to f9b96a3 Compare March 19, 2024 07:12
@soharab-ic
Copy link
Contributor Author

@narmidm Fixed the build failure issue.
E2E is failing because of this

"Error: INSTALLATION FAILED: failed to fetch https://raw.githubusercontent.com/kubeslice/dev-charts/gh-pages/nexus/kubeslice-controller-1.2.1.tgz : 404 Not Found",`

@NishantSingh10
Copy link
Contributor

report link 'https://kubeslice.github.io/e2e-allure-reports/Kind-worker-operator-2024-03-19T12:24:40-master-443/index.html'

@narmidm
Copy link
Member

narmidm commented Apr 3, 2024

@soharab-ic ,A release has recently occurred; could you please resolve the conflict on the branch?

@soharab-ic
Copy link
Contributor Author

@soharab-ic ,A release has recently occurred; could you please resolve the conflict on the branch?

Sure @narmidm

@soharab-ic soharab-ic force-pushed the reject-conflicting-alias-names-for-svcex branch from f9b96a3 to cd03978 Compare April 7, 2024 16:45
@soharab-ic
Copy link
Contributor Author

@narmidm Resolved conflicts, Please trigger E2E pipeline.

@soharab-ic
Copy link
Contributor Author

@narmidm @bharath-avesha Any update on the E2E pipeline?

@narmidm
Copy link
Member

narmidm commented Apr 16, 2024

@narmidm @bharath-avesha Any update on the E2E pipeline?

Fixed & started the pipeline.

@mridulgain
Copy link
Contributor

@soharab-ic a fix has been added for the e2e pipeline workflow. Please sync your branch.

@soharab-ic soharab-ic force-pushed the reject-conflicting-alias-names-for-svcex branch from cd03978 to 3fb42dd Compare April 17, 2024 04:38
@soharab-ic
Copy link
Contributor Author

@soharab-ic a fix has been added for the e2e pipeline workflow. Please sync your branch.

Synced my branch.
Thanks @mridulgain

@NishantSingh10
Copy link
Contributor

report link 'https://kubeslice.github.io/e2e-allure-reports/Kind-worker-operator-2024-04-17T07:32:56-master-471/index.html'

@soharab-ic
Copy link
Contributor Author

@narmidm @mridulgain I see three end-to-end tests are failing. Is the e2e pipeline have some issues?
I have not added any e2e tests.

@kon3m kon3m mentioned this pull request Apr 24, 2024
Open
2 tasks
@narmidm
Copy link
Member

narmidm commented Apr 24, 2024

@soharab-ic let me look into it. and I will rerun it again.

@soharab-ic
Copy link
Contributor Author

@narmidm Thanks for re-running the pipeline.
Did you find the cause for failure?

Just FYI, I have added a manifest file for validating webhook but did not update the helm chart yet. I was planning to update the helm chart after this PR is merged. I am expecting that this will not cause any issue for e2e tests.

@soharab-ic
fix(ServiceExport): Reject Conflicting Alias Names for ServiceExport …
5664b02 
…object

Added a validating webhook to verify alias names in serviceexport object
and reject and if there are conflicting aliases

Fixes kubeslice#315

Signed-off-by: Md Soharab Ansari <[email protected]>
@soharab-ic soharab-ic force-pushed the reject-conflicting-alias-names-for-svcex branch from 3fb42dd to 5664b02 Compare May 2, 2024 11:16
mridulgain
mridulgain approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@mridulgain mridulgain left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!
In the latest test report #337 (comment), a sufficient number of tests from the Worker and SliceHealth suites have passed to ensure that existing functionalities are unaffected. Notably, the iperf tests, which include ServiceExport creation to make the service available across clusters connected under the Slice, have also passed successfully.

@narmidm narmidm merged commit f59b1fc into kubeslice:master May 17, 2024
7 checks passed
@soharab-ic
Copy link
Contributor Author

Thanks everyone.

This was referenced May 17, 2024
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rahul-D78 Rahul-D78 Rahul-D78 approved these changes

@mridulgain mridulgain mridulgain approved these changes

@narmidm narmidm Awaiting requested review from narmidm narmidm is a code owner

@bharath-avesha bharath-avesha Awaiting requested review from bharath-avesha bharath-avesha is a code owner

@gourishkb gourishkb Awaiting requested review from gourishkb gourishkb is a code owner

Assignees

@soharab-ic soharab-ic

Labels
ready-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reject conflicting alias names for exported services
5 participants
@soharab-ic @narmidm @NishantSingh10 @mridulgain @Rahul-D78