-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(): Add slice gw edge feature to use a LB for inter-cluster traffic (test automation is WIP) #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bharath Horatti <[email protected]>
Signed-off-by: Bharath Horatti <[email protected]>
Set slicegatewayservice type in the slice object Signed-off-by: Bharath Horatti <[email protected]>
Signed-off-by: Bharath Horatti <[email protected]>
Signed-off-by: Bharath Horatti <[email protected]>
Added code comments Signed-off-by: Bharath Horatti <[email protected]>
bharath-avesha
requested review from
narmidm,
YachikaRalhan,
Rahul-D78,
rahulsawra98,
gourishkb and
mridulgain
as code owners
October 10, 2023 10:17
bharath-avesha
changed the title
feat(): Add slice gw edge feature to use a LB for inter-cluster traffic (test automation is WIP
feat(): Add slice gw edge feature to use a LB for inter-cluster traffic (test automation is WIP)
Oct 10, 2023
bharath-avesha
requested review from
narmidm and
YachikaRalhan
and removed request for
narmidm and
YachikaRalhan
October 10, 2023 10:18
Signed-off-by: Md Imran <[email protected]>
Signed-off-by: Md Imran <[email protected]>
Signed-off-by: Md Imran <[email protected]>
Signed-off-by: Md Imran <[email protected]>
Signed-off-by: Bharath Horatti <[email protected]>
Signed-off-by: Bharath Horatti <[email protected]>
Signed-off-by: Bharath Horatti <[email protected]>
Signed-off-by: Bharath Horatti <[email protected]>
narmidm
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introducing a slice gateway edge service of type LoadBalancer to receive all inter-cluster traffic from remote clusters of a slice. The backend for this service would be a passthrough proxy that uses NAT rules to forward the traffic to the right slice gateway vpn server pod. It will only be created on those clusters that are assigned to host one or more vpn servers.
The doc for this feature contains more details: https://docs.google.com/document/d/1nLHZpeeKd_LvK7fiXK0OExUB_8TS_HzS5eVYzrYGOy8/edit?usp=sharing
Fixes #
This is not a bug fix. This is a new feature.
How Has This Been Tested?
Tested this feature on cloud clusters where a service of type LoadBalancer could be created. On a two cluster setup, a slice with the slice gateway service type set to LB for the first cluster was created.
Verified that the slice gw edge service is created.
Verified that the service contains the correct ports list corresponding to the NodePort numbers of all the slice gw vpn servers.
Verified that the Slice Gw Edge (SGE) deployment is created automatically.
Verified that the operator sends the correct portmap to the SGE.
Verified that the SGE creates DNAT and MASQUERADE rules to forward the incoming traffic to the right vpn server pod.
Checklist:
go fmt
Does this PR introduce a breaking change?
NO