Merge pull request #356 from kubeslice/fix-docker-login

Update end-to-end-test.yaml
kubeslice · Mar 30, 2024 · db31a10 · db31a10
2 parents a39a8ef + 1360786
commit db31a10
Showing 1 changed file with 5 additions and 9 deletions.
diff --git a/.github/workflows/end-to-end-test.yaml b/.github/workflows/end-to-end-test.yaml
@@ -7,6 +7,8 @@ on:
 env:
   chartuser: ${{ secrets.DEV_CHARTS_USERNAME }}
   chartpassword: ${{ secrets.DEV_CHARTS_PASSWORD }}
+  dockeruser: ${{ secrets.DOCKER_USERNAME }}
+  dockerpassword: ${{ secrets.DOCKER_TOKEN }}
   ENFORCE_CRITICAL_CHECK: ${{ secrets.ENFORCE_CRITICAL_CHECK }}
 
 jobs:
@@ -100,18 +102,12 @@ jobs:
       env: 
          GITHUB_HEAD_COMMIT: ${{ steps.vars.outputs.sha_commit }}
 
-    - name: Login to Docker Hub
-      uses: docker/login-action@v3
-      with:
-        username: ${{ secrets.DOCKER_USERNAME }}
-        password: ${{ secrets.DOCKER_TOKEN }}
-
-    - name: Build the e2e image
-      run: sudo docker build . -t aveshadev/kubeslice-e2e:latest
-
     - name: Docker Run Action
       uses: addnab/docker-run-action@v3
       with:
+        username: ${{ env.dockeruser }}
+        password: ${{ env.dockerpassword }}
+        registry: docker.io
         image: aveshadev/kubeslice-e2e:latest
         options: -v ${{ github.workspace }}/reports:/e2e/reports -v /home/runner/.kube:/e2e/assets/kubeconfig -v ${{ github.workspace }}/profile:/e2e/profile --network kind
         run: |