Skip to content

Commit

Permalink
Merge pull request #396 from kubeslice/fix-slice
Browse files Browse the repository at this point in the history
fix: removed duplicate reconciliation calls
  • Loading branch information
mridulgain authored Aug 2, 2024
2 parents 46da36b + 5428d40 commit 02916ca
Showing 1 changed file with 0 additions and 29 deletions.
29 changes: 0 additions & 29 deletions controllers/slice/reconciler.go
Original file line number Diff line number Diff line change
Expand Up @@ -190,35 +190,6 @@ func (r *SliceReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl
}
}

if isIngressConfigured(slice) {
debugLog.Info("Installing ingress")
err = manifest.InstallIngress(ctx, r.Client, slice)
if err != nil {
log.Error(err, "unable to install ingress")
utils.RecordEvent(ctx, r.EventRecorder, slice, nil, ossEvents.EventSliceIngressInstallFailed, controllerName)
return ctrl.Result{}, nil
}
}

res, err, requeue = r.ReconcileSliceRouter(ctx, slice)
if err != nil {
log.Error(err, "Failed to reconcile slice router")
}
if requeue {
return res, err
}

res, err, requeue = r.ReconcileSliceGwEdge(ctx, slice)
if err != nil {
log.Error(err, "Slice Edge reconciliation failed")
return res, err
}
if requeue {
return ctrl.Result{
Requeue: true,
}, nil
}

debugLog.Info("reconciling app pods")
res, err, requeue = r.ReconcileAppPod(ctx, slice)
if err != nil {
Expand Down

0 comments on commit 02916ca

Please sign in to comment.