fix(): check if VPNConfig is nil for old slice (#175)

Signed-off-by: rahulsawra98 <[email protected]>
kubeslice · Jul 26, 2023 · 8614d72 · 8614d72
1 parent f610cfa
commit 8614d72
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/service/slice_config_webhook_validation.go b/service/slice_config_webhook_validation.go
@@ -348,9 +348,13 @@ func preventUpdate(ctx context.Context, sc *controllerv1alpha1.SliceConfig, old
 	if sliceConfig.Spec.SliceIpamType != sc.Spec.SliceIpamType {
 		return field.Invalid(field.NewPath("Spec").Child("SliceIpamType"), sc.Spec.SliceIpamType, "cannot be updated")
 	}
-	if sliceConfig.Spec.VPNConfig.Cipher != sc.Spec.VPNConfig.Cipher {
-		return field.Invalid(field.NewPath("Spec").Child("VPNConfig").Child("Cipher"), sc.Spec.VPNConfig.Cipher, "cannot be updated")
+	// required if slice from previous releases is upgraded
+	if sliceConfig.Spec.VPNConfig != nil {
+		if sliceConfig.Spec.VPNConfig.Cipher != sc.Spec.VPNConfig.Cipher {
+			return field.Invalid(field.NewPath("Spec").Child("VPNConfig").Child("Cipher"), sc.Spec.VPNConfig.Cipher, "cannot be updated")
+		}
 	}
+
 	return nil
 }