Update non-root user in Dockerfile #48
Open
+8
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yash2189
changed the title
|
Local Testing logs: |
|
@yash2189 your DCO check is failing please follow this link - https://github.com/kubeslice/kubeslice-controller/blob/master/CONTRIBUTING.md#contributor-compliance-with-developer-certificate-of-origin-dco
|
yash2189
force-pushed
the
dockerfile_changes
branch
2 times, most recently
from
fb7f407 to
a5f8d06
Compare
Signed-off-by: Yash Ajgaonkar <[email protected]> Signed-off-by: Yash Ajgaonkar <[email protected]>
yash2189
force-pushed
the
dockerfile_changes
branch
from
a5f8d06 to
11e9c76
Compare
|
@narmidm I have signed off my commit |
|
@yash2189 - Could you sync your branch with the master branch once? - we have new checks on PR. |
narmidm
approved these changes
May 20, 2024
|
@narmidm I have synced the branch |
|
LGTM! We will postpone the merging of this PR for a few days due to an ongoing release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated worker slice gateway sidecar
Dockerfilewith non-root userTested the changes by building the
Dockerfilelocally and creating a running container ofgateway-sidecarCloses #42