Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the detection of public Istio Gateways #645

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Fixing the detection of public Istio Gateways #645

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 23 additions & 7 deletions rules/exposure-to-internet-via-istio-ingress/raw.rego
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,12 @@ deny[msga] {
gateway.metadata.name == vs_gw.name
get_namespace(gateway) == vs_gw.namespace

# Find the connected Istio Ingress Gateway that should be a LoadBalancer if it is exposed to the internet
istioingressgateway := input[_]
istioingressgateway.kind == "Service"
istioingressgateway.metadata.namespace == "istio-system"
gateway.spec.selector[_] == istioingressgateway.metadata.labels[_]
# print("Found the gateway that the virtualservice is connected to", gateway)

# Check if the Istio Ingress Gateway is exposed to the internet
is_exposed_service(istioingressgateway)
# Either the gateway is exposed via LoadBalancer/n service OR has "public" suffix
is_gateway_public(gateway, input)

# print("Gateway is public", gateway)

# Check if the VirtualService is connected to an workload
# First, find the service that the VirtualService is connected to
Expand All @@ -40,15 +38,21 @@ deny[msga] {
# Check if the service is the target of the VirtualService
connected_service.metadata.name == target_name

# print("Found the service that the virtualservice is connected to", connected_service)

# Check if the service is connected to a workload
wl := input[_]
is_same_namespace(connected_service, wl)
spec_template_spec_patterns := {"Deployment", "ReplicaSet", "DaemonSet", "StatefulSet", "Pod", "Job", "CronJob"}
spec_template_spec_patterns[wl.kind]
wl_connected_to_service(wl, connected_service)

# print("Found the workload that the service is connected to", wl)

failedPaths := [sprintf("spec.http[%d].routes[%d].destination.host", [i,j])]

# print("Found the failed paths", failedPaths)

msga := {
"alertMessage": sprintf("workload '%v' is exposed through virtualservice '%v'", [wl.metadata.name, virtualservice.metadata.name]),
"packagename": "armo_builtins",
Expand All @@ -73,6 +77,18 @@ deny[msga] {

# ====================================================================================

is_gateway_public(gateway, inputs) {
endswith(gateway.metadata.name, "public")
}

is_gateway_public(gateway, inputs) {
inputs[_].kind == "Service"
inputs[_].metadata.namespace == "istio-system"
gateway.spec.selector[_] == inputs[_].metadata.labels[_]
is_exposed_service(inputs[_])
}


get_namespace(obj) = namespace {
obj.metadata
obj.metadata.namespace
Expand Down
Loading