Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix fixpath for controls C-0077 and C-0076 #522

Closed
wants to merge 7 commits into from

Conversation

YiscahLevySilas1
Copy link
Collaborator

@YiscahLevySilas1 YiscahLevySilas1 commented Oct 12, 2023

PR Type:

Bug fix


PR Description:

This PR addresses an issue with the formatting of label paths in Rego rules. The previous format used a dot notation which has been replaced with a bracket notation to correctly reference labels in the metadata. This change affects both the rules and their corresponding test files.


PR Main Files Walkthrough:

files:

rules/k8s-common-labels-usage/raw.rego: Changed the label path format from dot notation to bracket notation in the 'no_K8s_label_or_no_K8s_label_usage' functions.
rules/k8s-common-labels-usage/test/cronjob/expected.json: Updated the expected output to reflect the new label path format.
rules/k8s-common-labels-usage/test/pod/expected.json: Updated the expected output to reflect the new label path format.
rules/k8s-common-labels-usage/test/workload-fail/expected.json: Updated the expected output to reflect the new label path format.
rules/label-usage-for-resources/raw.rego: Changed the label path format from dot notation to bracket notation in the 'no_label_or_no_label_usage' functions.
rules/label-usage-for-resources/test/cronjob/expected.json: Updated the expected output to reflect the new label path format.
rules/label-usage-for-resources/test/workload-fail/expected.json: Updated the expected output to reflect the new label path format.


User Description:

Overview

YiscahLevySilas1 and others added 7 commits October 9, 2023 16:32
Signed-off-by: YiscahLevySilas1 <[email protected]>
…85-fix-control-C-0262

Signed-off-by: YiscahLevySilas1 <[email protected]>
Signed-off-by: YiscahLevySilas1 <[email protected]>
…golibrary into SUB-2185-fix-control-C-0262

Signed-off-by: YiscahLevySilas1 <[email protected]>
…85-fix-control-C-0262

Signed-off-by: YiscahLevySilas1 <[email protected]>
Signed-off-by: YiscahLevySilas1 <[email protected]>
@YiscahLevySilas1 YiscahLevySilas1 changed the title Sub 2185 fix control c 0262 fix fixpath for controls C-0077 and C-0076 Oct 12, 2023
@codiumai-pr-agent-free
Copy link
Contributor

PR Analysis

  • 🎯 Main theme: Fixing label path formatting in Rego rules
  • 📝 PR summary: This PR addresses an issue with the formatting of label paths in Rego rules. The previous format used a dot notation which has been replaced with a bracket notation to correctly reference labels in the metadata. This change affects both the rules and their corresponding test files.
  • 📌 Type of PR: Bug fix
  • 🧪 Relevant tests added: Yes
  • ⏱️ Estimated effort to review [1-5]: 2, because the PR is straightforward and involves only changes in the formatting of label paths in Rego rules and their corresponding test files.
  • 🔒 Security concerns: No security concerns found

PR Feedback

How to use

To invoke the PR-Agent, add a comment using one of the following commands:
/review [-i]: Request a review of your Pull Request. For an incremental review, which only considers changes since the last review, include the '-i' option.
/describe: Modify the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest improvements to the code in the PR. Extended mode employs several calls, and provides a more thorough feedback.
/ask <QUESTION>: Pose a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.

To edit any configuration parameter from configuration.toml, add --config_path=new_value
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, use the /config command.

@YiscahLevySilas1 YiscahLevySilas1 deleted the SUB-2185-fix-control-C-0262 branch October 12, 2023 14:19
@github-actions
Copy link
Contributor

Summary:

  • License scan: failure
  • Credentials scan: success
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: success

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant