Add Regal linting in CI pipeline #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplified now by the new [setup-regal](https://github.com/StyraInc/setup-regal) GitHub Action. The new-ish `--format github` flag will also annotate PRs with any violation encountered in the code at the location of the violation, making it really easy to spot. Also fixed some style violations from more recent Regal rules, and amended the Regal configuration to ignore some of the new rules that would require more work to enable. Let me know what you all think, and have a great weekend! Signed-off-by: Anders Eknert <[email protected]>
|
Hi @anderseknert, welcome back! |
|
Fantastic! Thanks @alegrey91 👍 Would love to hear about your experience with Regal later. Until then, take care! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello kubescape friends!
Regal integration in CI just made simpler thanks to the new setup-regal GitHub Action, so I figured I'd check back :)
The new-ish
--format githubflag will also annotate PRs with any violation encountered in the code at the location of the violation, making it really easy to spot.Also fix some style violations from more recent Regal rules, like excessive whitespace or comments without whitespace. That made the PR a little noisy, but it should be fairly quick to skim through.
Let me know what you all think, and have a great weekend!