fail if the provided user name is not k8s compliant #94
+85
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatousJobanek
requested review from
xcoulon,
alexeykazakov,
rajivnathan,
ranakan19,
mfrancisc,
drpaneas,
metlos and
fbm3307
as code owners
xcoulon
approved these changes
Dec 17, 2024
it's much simpler and much better than sanitizing the username, indeed! |
mfrancisc
reviewed
Dec 17, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #94 +/- ##
==========================================
+ Coverage 67.78% 68.02% +0.23%
==========================================
Files 44 44
Lines 3216 3240 +24
==========================================
+ Hits 2180 2204 +24
Misses 841 841
Partials 195 195
|
mfrancisc
approved these changes
Dec 17, 2024
alexeykazakov
approved these changes
Dec 17, 2024
| err := ensureUsers(clusterCtx, objectsCache{}) | ||
|
|
||
| // then | ||
| require.Error(t, err) |
There was a problem hiding this comment.
I usually prefer checking the actual error just to make sure the error message is informative and it's actually the expected error and not something else. Unless it's tricky to hardcode the expected error message in the test.
There was a problem hiding this comment.
+1 to checking the actual error
There was a problem hiding this comment.
see #94 (comment)
fbm3307
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we should fail if the provided name of the user is not compliant with k8s names and label values.