Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename sandbox-cli to ksctl #8

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

MatousJobanek
Copy link
Contributor

rename all occurrences of sandbox-cli to ksctl

@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 65.28%. Comparing base (cdcbceb) to head (26cdd2f).

Files Patch % Lines
pkg/cmd/adm/setup.go 0.00% 2 Missing ⚠️
pkg/client/sandbox_config_file.go 0.00% 1 Missing ⚠️
pkg/cmd/adm/generate_cli_configs.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master       #8   +/-   ##
=======================================
  Coverage   65.28%   65.28%           
=======================================
  Files          38       38           
  Lines        1982     1982           
=======================================
  Hits         1294     1294           
  Misses        529      529           
  Partials      159      159           
Flag Coverage Δ
unittests 65.28% <63.63%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ranakan19 ranakan19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, need to make yaml linter happy

@MatousJobanek MatousJobanek merged commit 8e21766 into kubesaw:master Mar 15, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants