-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[install-kubeadm]: Update instructions to disable or tolerate swap #47710
[install-kubeadm]: Update instructions to disable or tolerate swap #47710
Conversation
/cc @pacoxu @neolit123 |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this change specific to v1.32?
if so the change should be for the dev-1.32 branch. not main.
content/en/docs/setup/production-environment/tools/kubeadm/install-kubeadm.md
Outdated
Show resolved
Hide resolved
content/en/docs/setup/production-environment/tools/kubeadm/install-kubeadm.md
Outdated
Show resolved
Hide resolved
6ca8520
to
0d9289b
Compare
Nope, this is relevant from 1.30 and onwards 👍 |
/sig node |
/sig cluster-lifecycle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, I don't think that turning swap off is a prerequisite any more; rather than list that as a prerequisite, let's have a new heading about Linux nodes and swap where we explain how to either check things are right, or advise on what to change.
(I'd reiterate Linux here even though Linux is a prerequisite, because Windows nodes have supported running with swap active for many years).
content/en/docs/setup/production-environment/tools/kubeadm/install-kubeadm.md
Outdated
Show resolved
Hide resolved
content/en/docs/setup/production-environment/tools/kubeadm/install-kubeadm.md
Outdated
Show resolved
Hide resolved
Just find that kernel requirement of kubernetes/kubernetes@2a174d0 is not mentioned in doc.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @pacoxu! Yeah I've looked at this document, great job! In any case, this is a bit out of scope for this PR :) do you mind discussing this offline or elsewhere? |
0d9289b
to
a74e030
Compare
Signed-off-by: Itamar Holder <[email protected]>
Signed-off-by: Itamar Holder <[email protected]>
Signed-off-by: Itamar Holder <[email protected]>
a74e030
to
3b09c30
Compare
Agree. The scope and change of this PR LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
thanks
LGTM label has been added. Git tree hash: 722a7459fed78e674361dedfc90c3c3fe5b21217
|
Swap is not required to be turned off any more. This change makes sense |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pacoxu, reylejano The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Addresses kubernetes/kubeadm#2563 (comment).
Updates the instructions regarding swap configuration:
Issue
Closes: kubernetes/kubeadm#2563
Addresses kubernetes/kubeadm#2563 (comment).
Changes overview