Add update-mocks Makefile target #1794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new `update-mocks` Make target allows us to generate the mocks with preserving the boilerplate header. Signed-off-by: Sascha Grunert <[email protected]>
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
sig/release
cpanato
reviewed
Nov 26, 2020
| update-mocks: ## Update all generated mocks | ||
| go generate ./... | ||
| for f in $(shell find . -name fake_*.go); do \ | ||
| cp hack/boilerplate/boilerplate.go.txt tmp ;\ |
There was a problem hiding this comment.
in the files that we set the //go:generate... we can add
//go:generate /usr/bin/env bash -c "cat ../../hack/boilerplate/boilerplate.go.txt service_mock.go > _service_mock.go && mv _service_mock.go service_mock.go"
so that will add the headers as well when we run the go generate ./...
wdty?
There was a problem hiding this comment.
Hm, I'm not sure if I prefer moving the complexity directly into the go generate invocation. We also have this discussion open around that: maxbrunsfeld/counterfeiter#98
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
The new
update-mocksMake target allows us to generate the mocks withpreserving the boilerplate header.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?