Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for content in config #1952

Merged
merged 4 commits into from
Dec 2, 2024
Merged

Add support for content in config #1952

merged 4 commits into from
Dec 2, 2024

Conversation

jvitor83
Copy link
Contributor

@jvitor83 jvitor83 commented Nov 6, 2024

Closes #1947

What type of PR is this?

/kind feature

What this PR does / why we need it:

Added support to content in config element.
Unit test included.

Which issue(s) this PR fixes:

Fixes #1947

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 6, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 6, 2024
cdrage
cdrage requested changes Nov 6, 2024
View reviewed changes
Copy link
Member

@cdrage cdrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code looks amazing! Could you please update the documentation matrix as well for compatibility?

I believe we need to add another entry there. https://github.com/kubernetes/kompose/blob/main/docs/conversion.md

Otherwise, awesome code / changes and AMAZING tests. Big thanks!

@jvitor83
Copy link
Contributor Author

Done as asked!
@cdrage

hangyan
hangyan reviewed Nov 18, 2024
View reviewed changes
pkg/transformer/kubernetes/kubernetes.go Outdated Show resolved Hide resolved
pkg/transformer/kubernetes/k8sutils_test.go
@@ -231,6 +232,97 @@ func TestCreateServiceWithServiceUser(t *testing.T) {
}
}

func TestCreateServiceWithConfigLongSyntax(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cdrage are the e2e tests still running?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they should, looks like it passed on this PR.

@cdrage
Copy link
Member

cdrage commented Nov 27, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 27, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cdrage, jvitor83

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2024
@cdrage
Copy link
Member

cdrage commented Nov 28, 2024

Closes #1947

What type of PR is this?

/kind feature

What this PR does / why we need it:

Added support to content in config element. Unit test included.

Which issue(s) this PR fixes:

Fixes #1947

Hi sorry, can you fix the invalid commit message error, and we should be good to go!

@jvitor83 jvitor83 force-pushed the feature/config-content branch from 5bc3ff9 to a495420 Compare November 29, 2024 00:17
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. labels Nov 29, 2024
@jvitor83
Copy link
Contributor Author

Closes #1947

What type of PR is this?

/kind feature

What this PR does / why we need it:

Added support to content in config element. Unit test included.

Which issue(s) this PR fixes:

Fixes #1947

Hi sorry, can you fix the invalid commit message error, and we should be good to go!

I guess it is ok now @cdrage

@hangyan
Copy link
Contributor

hangyan commented Nov 30, 2024

/lgtm

@k8s-ci-robot
Copy link
Contributor

@hangyan: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cdrage
Copy link
Member

cdrage commented Dec 2, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2024
@k8s-ci-robot k8s-ci-robot merged commit 62d33c4 into kubernetes:main Dec 2, 2024
10 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Dec 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdrage cdrage cdrage requested changes

@hangyan hangyan hangyan left review comments

@TessaIO TessaIO Awaiting requested review from TessaIO

Assignees

@cdrage cdrage

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for content in top-level config
4 participants
@jvitor83 @cdrage @k8s-ci-robot @hangyan