cleanup: removes uneeded annotation when not using network policy #1884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/cleanup
k8s-ci-robot
added
approved
cdrage
force-pushed
the
remove-network-label-is-default
branch
from
de902d5 to
22be122
Compare
k8s-ci-robot
added
size/S
|
Not sure what I'm doing wrong here @TessaIO :( it's been a while since I've tested this locally, but I cant seem to get it to work with test-cmd and such on mac M1. Are you able to fix these tests by any change? |
cdrage
force-pushed
the
remove-network-label-is-default
branch
from
22be122 to
86a0ec2
Compare
k8s-ci-robot
added
size/L
cdrage
force-pushed
the
remove-network-label-is-default
branch
2 times, most recently
from
ac64858 to
e06528f
Compare
|
Failing because #1886 needs to go in |
#### What type of PR is this? <!-- Add one of the following kinds: /kind bug /kind documentation /kind feature --> /kind cleanup #### What this PR does / why we need it: Removes the network policy annotation which is not needed (we are not generating network policy) #### Which issue(s) this PR fixes: <!-- *Automatically closes linked issue when PR is merged. Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> Fixes kubernetes#1759 #### Special notes for your reviewer:
cdrage
force-pushed
the
remove-network-label-is-default
branch
from
e06528f to
8c96029
Compare
TessaIO
approved these changes
Jun 2, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cdrage, TessaIO The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cleanup: removes uneeded annotation when not using network policy
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Removes the network policy annotation which is not needed (we are not
generating network policy)
Which issue(s) this PR fixes:
Fixes #1759
Special notes for your reviewer: