-
Notifications
You must be signed in to change notification settings - Fork 770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(cli): introduce examples in the kompose command #1808
Conversation
Signed-off-by: Martin Jirku <[email protected]>
cmd/convert.go
Outdated
@@ -79,6 +79,9 @@ var ( | |||
var convertCmd = &cobra.Command{ | |||
Use: "convert", | |||
Short: "Convert a Docker Compose file", | |||
Example: ` kompose --file docker-voting.yml convert |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've removed the voting and guestbook examples and we're trying to go away from using docker-compose.yml / .yml
since compose is an open spec.
I think we should just put compose.yaml
as even saying .yml
is deprecated.
If that's good with you 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries, I will update it, so it will be consistent with the #1803.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated! 🎆
Signed-off-by: Martin Jirku <[email protected]>
Signed-off-by: Martin Jirku <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cdrage, martinjirku The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
This PR adds few basic examples to the cli command.
Which issue(s) this PR fixes:
Fixes #1717
Special notes for your reviewer:
I've considered to update
Long
instead adding theExamples
field. However, it looked more clear to introduce these few examples. Maybe later, there will be more content to add into Long with specific examples.The result of running
kompose
The result of
kompose convert --help
: