docs: replace gcr.io with nginx docker image #1802
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/documentation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AhmedGrati The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Signed-off-by: AhmedGrati <[email protected]>
AhmedGrati
force-pushed
the
fix-user-guide-not-found-image
branch
from
ef5407f to
d7daaa5
Compare
|
We should merge #1801 to get this CI happy. |
|
Sorry I was a bit late with this! I've opened up #1803 which uses a working application I had been working on with another team. We could use this as a custom example |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind documentation
What this PR does / why we need it:
This PR aims to replace the
gcr.io/google-samples/gb-frontend:v4with thenginximage since the former is not found (probably deleted).Which issue(s) this PR fixes:
Fixes #1789