Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove status field from generated yaml #1746

Merged
merged 4 commits into from
Oct 30, 2023
Merged

remove status field from generated yaml #1746

merged 4 commits into from
Oct 30, 2023

Conversation

shubhindia
Copy link
Contributor

/kind feature

What type of PR is this?

Whenever the k8s yamls are generated, since status field is part of APIs, it is being added in the generated yamls, which is fine but should not be there since the objects are not applied yet.

What this PR does / why we need it:

This just adds a simple hack to remove the status field from generated yamls

Which issue(s) this PR fixes:

Fixes #975

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 29, 2023
@k8s-ci-robot k8s-ci-robot requested review from cdrage and kadel October 29, 2023 06:42
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 29, 2023
@shubhindia shubhindia mentioned this pull request Oct 29, 2023
Closed
@AhmedGrati
Copy link
Contributor

@shubhindia It seems that there are some status'es that are not deleted yet in the test files.

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 30, 2023
@shubhindia
Copy link
Contributor Author

shubhindia commented Oct 30, 2023 •
edited
Loading

@shubhindia It seems that there are some status'es that are not deleted yet in the test files.

@AhmedGrati pushed a commit to remove those.

@shubhindia shubhindia force-pushed the fix/drop-status-field branch from 5ebc4b1 to ffe7691 Compare October 30, 2023 09:42
@shubhindia shubhindia force-pushed the fix/drop-status-field branch from ffe7691 to 204dff4 Compare October 30, 2023 09:46
cdrage
cdrage requested changes Oct 30, 2023
View reviewed changes
pkg/transformer/utils.go Outdated Show resolved Hide resolved
@cdrage
Copy link
Member

cdrage commented Oct 30, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cdrage, shubhindia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cdrage, shubhindia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 30, 2023
@cdrage
Copy link
Member

cdrage commented Oct 30, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 30, 2023
@k8s-ci-robot k8s-ci-robot merged commit 3bbb75f into kubernetes:main Oct 30, 2023
8 checks passed
@Porkepix Porkepix mentioned this pull request Jan 18, 2024
Merged
@jaapenstaart jaapenstaart mentioned this pull request Apr 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdrage cdrage cdrage approved these changes

@kadel kadel Awaiting requested review from kadel

Assignees

@cdrage cdrage

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove status field in the generated yaml
4 participants
@shubhindia @AhmedGrati @cdrage @k8s-ci-robot