Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump coredns and kubernetes dependencies #649

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Bump coredns and kubernetes dependencies #649

merged 3 commits into from
Nov 13, 2024

Conversation

dereknola
Copy link
Contributor

@dereknola dereknola commented Oct 18, 2024 •
edited
Loading

Background

These two dependencies are very Out of Date and are introducing CVEs into downstream repos.
A previous PR was auto opened by dependabot, but never went anywhere. #641
This PRs scope is more limited.

Changes

  • Bump coredns to 1.11.3 (latest version)
  • Bump K8s to 1.28.14 (the oldest version still being supported as of October 2024). This should ensure maximum compatibility.
  • Migrate from deprecated clock package to replacement (clocks and clocks/testing got split up)

The go mod vendor has been isolated to a separate commit to make review easier.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 18, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @dereknola!

It looks like this is your first PR to kubernetes/dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 18, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @dereknola. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 18, 2024
@dereknola
Copy link
Contributor Author

@DamianSawicki Can I get a review on this please? I'm not sure who else to ping, as there hasn't been much activity in this repo in about 4 months.

Related, does this repo need more maintainers?

@DamianSawicki
Copy link
Collaborator

Hi @dereknola, I think this repo desperately needs more maintainers. Currently no PR can be submitted (at least normally) because CI is broken (so there is little sense in reviewing your PR before resolving this). If you have the capacity to look at #646, it would be really great.

@dereknola
Copy link
Contributor Author

@DamianSawicki I've rebased this PR now that the E2E fix is in master.

@DamianSawicki
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 26, 2024
@dereknola
Copy link
Contributor Author

/retest

@dereknola
Copy link
Contributor Author

Looks like the 5s timeout I added in the last PR is still not quite enough to prevent flaky e2e tests. Might consider bumping it to 10s.

@dereknola
Copy link
Contributor Author

@kl52752 Could you review this please? I will squash these commits, I just was waiting for review readability.

@DamianSawicki
Copy link
Collaborator

I'm also happy to review it but won't have time this week.

@dereknola
Copy link
Contributor Author

@DamianSawicki any chance you will have time this week to review this PR? I would love to pull this in to RKE2 November patches.

@DamianSawicki
Copy link
Collaborator

Apologies for the delay. It all looks good.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 7, 2024
@dereknola
Copy link
Contributor Author

@kl52752 any chance of getting this approved/reviewed?

@kl52752
Copy link
Collaborator

kl52752 commented Nov 13, 2024

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DamianSawicki, dereknola, kl52752, VestigeJ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2024
@k8s-ci-robot k8s-ci-robot merged commit fe97ec9 into kubernetes:master Nov 13, 2024
3 checks passed
This was referenced Nov 13, 2024
Open
Closed
@dereknola
Copy link
Contributor Author

Can we get a new release tagged now that this PR is merged?

@DamianSawicki
Copy link
Collaborator

Sure, I'll take care of it, hopefully tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VestigeJ VestigeJ VestigeJ approved these changes

@kl52752 kl52752 Awaiting requested review from kl52752

@MrHohn MrHohn Awaiting requested review from MrHohn

Assignees

@DamianSawicki DamianSawicki

@kl52752 kl52752

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dereknola @k8s-ci-robot @DamianSawicki @kl52752 @VestigeJ