Add test for empty ip (#611)

kubernetes · Mar 25, 2022 · 9c62385 · 9c62385
1 parent d2d1ba6
commit 9c62385
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 7 deletions.
diff --git a/pkg/cloudprovider/vsphere/nodemanager_test.go b/pkg/cloudprovider/vsphere/nodemanager_test.go
@@ -1514,6 +1514,15 @@ func TestDiscoverNodeIPs(t *testing.T) {
 			},
 			expectedErrorSubstring: "unable to find suitable IP address for node",
 		},
+		{
+			testName: "whenVCreturnsEmptyGuestNicInfo",
+			setup: testSetup{
+				ipFamilyPriority: []string{"ipv4"},
+				cpiConfig:        nil,
+				networks:         []vimtypes.GuestNicInfo{},
+			},
+			expectedErrorSubstring: "VM GuestNicInfo is empty",
+		},
 	}
 
 	for _, testcase := range testcases {

diff --git a/...cloudprovider/vsphereparavirtual/controllers/routablepod/ippool/ippool_controller_test.go b/...cloudprovider/vsphereparavirtual/controllers/routablepod/ippool/ippool_controller_test.go
@@ -148,16 +148,16 @@ func TestProcessIPPoolCreateOrUpdate(t *testing.T) {
 			c, cs := newController()
 
 			if _, err := c.ippoolclientset.NsxV1alpha1().IPPools(testClusterNS).Create(context.Background(), &testIPPool, metav1.CreateOptions{}); err != nil {
-				t.Errorf("failed to create test ippool %s: %w", testIPPool.Name, err)
+				t.Errorf("failed to create test ippool %s: %v", testIPPool.Name, err)
 			}
 
 			if err := c.processIPPoolCreateOrUpdate(&testIPPool); err != nil {
-				t.Errorf("failed to processIPPoolCreateOrUpdate %v: %w", testIPPool, err)
+				t.Errorf("failed to processIPPoolCreateOrUpdate %v: %v", testIPPool, err)
 			}
 
 			for _, n := range tc.nodes {
 				if _, err := c.kubeclientset.CoreV1().Nodes().Create(context.Background(), &n, metav1.CreateOptions{}); err != nil {
-					t.Errorf("failed to create test node %s: %w", n.Name, err)
+					t.Errorf("failed to create test node %s: %v", n.Name, err)
 				}
 			}
 

diff --git a/pkg/cloudprovider/vsphereparavirtual/controllers/routablepod/node/node_controller_test.go b/pkg/cloudprovider/vsphereparavirtual/controllers/routablepod/node/node_controller_test.go
@@ -131,12 +131,12 @@ func TestProcessNodeCreateOrUpdate(t *testing.T) {
 			// create nodes and run process processNodeCreateOrUpdate
 			for _, n := range tc.nodes {
 				if err := ippc.processNodeCreateOrUpdate(&n); err != nil {
-					t.Errorf("failed to create test node %s: %w", n.Name, err)
+					t.Errorf("failed to create test node %s: %v", n.Name, err)
 				}
 			}
 			for _, n := range tc.nodesUpdate {
 				if err := ippc.processNodeCreateOrUpdate(&n); err != nil {
-					t.Errorf("failed to create test node %s: %w", n.Name, err)
+					t.Errorf("failed to create test node %s: %v", n.Name, err)
 				}
 			}
 
@@ -231,14 +231,14 @@ func TestProcessNodeDelete(t *testing.T) {
 			if tc.ippoolExist {
 				// pre create test nodes
 				if _, err := createIPPool(ippcs, tc.nodes); err != nil {
-					t.Errorf("failed to create ippool %w", err)
+					t.Errorf("failed to create ippool %v", err)
 				}
 			}
 
 			// delete node
 			for _, n := range tc.nodesToBeDeleted {
 				if err := ippc.processNodeDelete(n.Name); err != nil {
-					t.Errorf("failed to create test node %s: %w", n.Name, err)
+					t.Errorf("failed to create test node %s: %v", n.Name, err)
 				}
 			}