Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] add support for context #2717

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[core] add support for context #2717

wants to merge 1 commit into from

Conversation

kayrus
Copy link
Contributor

@kayrus kayrus commented Nov 15, 2024

What this PR does / why we need it:

Add more context transparency

Which issue this PR fixes(if applicable):
fixes #

Special notes for reviewers:

Release note:

NONE

@kayrus kayrus requested review from dulek and zetaab November 15, 2024 19:50
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 15, 2024
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 15, 2024
@kayrus
Copy link
Contributor Author

kayrus commented Nov 15, 2024

/test openstack-cloud-controller-manager-ovn-e2e-test

@kayrus
Copy link
Contributor Author

kayrus commented Nov 16, 2024

@zetaab @dulek ready for review

zetaab
zetaab approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@zetaab zetaab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 20, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zetaab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2024
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 20, 2024
@kayrus
Copy link
Contributor Author

kayrus commented Nov 20, 2024

/retest-required

1 similar comment
@kayrus
Copy link
Contributor Author

kayrus commented Nov 20, 2024

/retest-required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zetaab zetaab zetaab approved these changes

@dulek dulek Awaiting requested review from dulek

@FengyunPan2 FengyunPan2 Awaiting requested review from FengyunPan2

@lingxiankong lingxiankong Awaiting requested review from lingxiankong

Assignees

@zetaab zetaab

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kayrus @k8s-ci-robot @zetaab