-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce noRetry Parameter for checkcapacity ProvisioningRequest #7496
Conversation
Welcome @PBundyra! |
Hi @PBundyra. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/assign @yaroslava-serdiuk |
/assign @aleksandra-malinowska |
/ok-to-test |
Could you add a test case for your change? The majority of cases live in orchestrator_test file. |
cluster-autoscaler/provisioningrequest/checkcapacity/provisioningclass.go
Outdated
Show resolved
Hide resolved
cluster-autoscaler/provisioningrequest/checkcapacity/provisioningclass.go
Outdated
Show resolved
Hide resolved
Thanks, added |
cluster-autoscaler/provisioningrequest/provreqwrapper/wrapper.go
Outdated
Show resolved
Hide resolved
cluster-autoscaler/provisioningrequest/checkcapacity/provisioningclass.go
Outdated
Show resolved
Hide resolved
/lgtm |
/lgtm Couple of nits only, otherwise LGTM. Feel free to remove hold when you consider this ready. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aleksandra-malinowska, PBundyra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cluster-autoscaler/provisioningrequest/checkcapacity/provisioningclass.go
Outdated
Show resolved
Hide resolved
cluster-autoscaler/provisioningrequest/checkcapacity/provisioningclass.go
Outdated
Show resolved
Hide resolved
cluster-autoscaler/provisioningrequest/orchestrator/orchestrator_test.go
Outdated
Show resolved
Hide resolved
Thanks for reviews |
/lgtm |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Introduces a new Parameter for checkcapacity ProvisioningRequests that limits retry mechanism in ClusterAutoscaler.
If the capacity can't be found then the ProvisioningRequest is marked as
Failed=True
instead ofProvisioned=False
Which issue(s) this PR fixes:
Fixes #7495
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: