Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kserve - initial additions, serving runtimes #10

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

kserve - initial additions, serving runtimes #10

wants to merge 5 commits into from

Conversation

spolti
Copy link

@spolti spolti commented Aug 27, 2024

No description provided.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: spolti
Once this PR has been reviewed and has the lgtm label, please assign jeffwan for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Aug 27, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@spolti spolti marked this pull request as draft August 27, 2024 18:07
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 27, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @spolti!

It looks like this is your first PR to kubernetes-sigs/wg-serving 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/wg-serving has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 27, 2024
terrytangyuan
terrytangyuan reviewed Aug 27, 2024
View reviewed changes
.idea/.gitignore Outdated Show resolved Hide resolved
terrytangyuan
terrytangyuan reviewed Sep 4, 2024
View reviewed changes
go.mod Outdated
Comment on lines 1 to 3
module wg-serving

go 1.22
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, not sure how it ended up here, thanks for the heads up.

serving-catalog/kserve/README.md Outdated
Comment on lines 13 to 39
# TODOs

- [ ] Add the inference services
- [ ] Use kustomize to deploy the runtimes and inference services
- [ ] Update the catalog once the examples are ready
- [ ] Update the validate script to check the KServe examples
- [ ] Update the catalog.md once the inference services and the kustomize deployment are ready
- [ ] Add custom Serving Runtimes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these TODOs for this PR?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for the PR exclusively, but to use as guidance for upcoming work and adjustments.

@spolti spolti force-pushed the kserve branch 2 times, most recently from cf2e9b4 to 23c4370 Compare September 18, 2024 17:40
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 18, 2024
@spolti spolti force-pushed the kserve branch 3 times, most recently from 1328a9a to 9bf9ea6 Compare September 19, 2024 00:48
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 21, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 11, 2024
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 11, 2024
@spolti
Copy link
Author

spolti commented Nov 11, 2024

@terrytangyuan please take a look, I've changed it a little bit, if that sounds good, we can add the vllm example later

@spolti
add .gitignore
991b54c 
Signed-off-by: Spolti <[email protected]>
@spolti spolti marked this pull request as ready for review December 30, 2024 18:08
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 30, 2024
@k8s-ci-robot k8s-ci-robot requested a review from Jeffwan December 30, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrytangyuan terrytangyuan terrytangyuan left review comments

@rhuss rhuss rhuss left review comments

@ahg-g ahg-g Awaiting requested review from ahg-g

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

@Jeffwan Jeffwan Awaiting requested review from Jeffwan

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spolti @k8s-ci-robot @rhuss @terrytangyuan