Skip to content

Commit

Permalink
Merge pull request #279 from kannon92/sync-docker-kueue
Browse files Browse the repository at this point in the history
update golang to 1.23 and fix docker warnings
  • Loading branch information
k8s-ci-robot authored Dec 12, 2024
2 parents 4019a94 + 1011463 commit 4cf14ac
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
9 changes: 4 additions & 5 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
ARG BASE_IMAGE
ARG BUILDER_IMAGE
ARG BUILDER_IMAGE=golang:1.23
ARG BASE_IMAGE=gcr.io/distroless/static:nonroot

# Build the manager binary
FROM ${BUILDER_IMAGE} as builder
FROM ${BUILDER_IMAGE} AS builder
ARG TARGETOS
ARG TARGETARCH
ARG CGO_ENABLED

WORKDIR /workspace
# Copy the Go Modules manifests
Expand All @@ -29,7 +28,7 @@ COPY pkg/utils pkg/utils
# was called. For example, if we call make docker-build in a local env which has the Apple Silicon M1 SO
# the docker BUILDPLATFORM arg will be linux/arm64 when for Apple x86 it will be linux/amd64. Therefore,
# by leaving it empty we can ensure that the container and binary shipped on it will have the same platform.
RUN CGO_ENABLED=${CGO_ENABLED} GOOS=${TARGETOS:-linux} GOARCH=${TARGETARCH} go build -a -o manager cmd/main.go
RUN CGO_ENABLED=${CGO_ENABLED:-0} GOOS=${TARGETOS:-linux} GOARCH=${TARGETARCH} go build -a -o manager cmd/main.go

FROM ${BASE_IMAGE}
WORKDIR /
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module sigs.k8s.io/lws

go 1.22.0
go 1.23.0

require (
github.com/google/go-cmp v0.6.0
Expand Down

0 comments on commit 4cf14ac

Please sign in to comment.