-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 fix helm plugin name occurrence #4319
🐛 fix helm plugin name occurrence #4319
Conversation
helm plugin name was renamed to "helm.kubebuilder.io/v1-alpha" (pkg/cli/alpha/internal/generate.go) but help messages and documentation still mentioning the plugin as helm/v1-alpha. Signed-off-by: Mario Constanti <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bavarianbidi The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @bavarianbidi! |
Hi @bavarianbidi. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hi @bavarianbidi, Thank you for reviewing this! I wanted to clarify that we're intentionally using the helm/v1-alpha naming convention (without the domain). This approach simplifies things for users, providing a more straightforward reference. The full name, as you indicated, would indeed be helm.kubebuilder.io/v1-alpha, but for our purposes, the domain inclusion isn’t necessary and we aim to keep it simple. With that in mind, I’ll go ahead and close this PR as "not accepted." However, please feel free to re-open if you believe it still needs further discussion. Thanks again! |
@camilamacedo86 thanks for closing the PR. And instead of try out the |
Thank you a lot for looking in how to contribute with |
helm plugin name was renamed to "helm.kubebuilder.io/v1-alpha" (pkg/cli/alpha/internal/generate.go) but help messages and documentation still mentioning the plugin as helm/v1-alpha.
The generic issue is already tracked in #4309