Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix helm plugin name occurrence #4319

Closed

Conversation

bavarianbidi
Copy link
Contributor

@bavarianbidi bavarianbidi commented Nov 11, 2024

helm plugin name was renamed to "helm.kubebuilder.io/v1-alpha" (pkg/cli/alpha/internal/generate.go) but help messages and documentation still mentioning the plugin as helm/v1-alpha.

The generic issue is already tracked in #4309

helm plugin name was renamed to "helm.kubebuilder.io/v1-alpha"
(pkg/cli/alpha/internal/generate.go) but help messages and documentation
still mentioning the plugin as helm/v1-alpha.

Signed-off-by: Mario Constanti <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 11, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bavarianbidi
Once this PR has been reviewed and has the lgtm label, please assign kavinjsir for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Welcome @bavarianbidi!

It looks like this is your first PR to kubernetes-sigs/kubebuilder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubebuilder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @bavarianbidi. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 11, 2024
@camilamacedo86
Copy link
Member

Hi @bavarianbidi,

Thank you for reviewing this!

I wanted to clarify that we're intentionally using the helm/v1-alpha naming convention (without the domain). This approach simplifies things for users, providing a more straightforward reference.

The full name, as you indicated, would indeed be helm.kubebuilder.io/v1-alpha, but for our purposes, the domain inclusion isn’t necessary and we aim to keep it simple.

With that in mind, I’ll go ahead and close this PR as "not accepted." However, please feel free to re-open if you believe it still needs further discussion.

Thanks again!

@bavarianbidi
Copy link
Contributor Author

@camilamacedo86 thanks for closing the PR.
i was mixing the issue with the latest released version of kubebuilder (which doesn't has the support for helm yet) and after builder the latest master branch i've just realized that the full-name contains the kubebuilder.io as well.

And instead of try out the helm/v1-alpha argument, i've just done a search and replace 😅

@camilamacedo86
Copy link
Member

Thank you a lot for looking in how to contribute with
Please, feel free to raise other prs and etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants