Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add t-mialve to owners #174

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Add t-mialve to owners #174

merged 1 commit into from
Sep 5, 2024

Conversation

t-mialve
Copy link
Collaborator

@t-mialve t-mialve commented Sep 4, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Add t-mialve to owners

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 4, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Sep 4, 2024
@coveralls
Copy link

coveralls commented Sep 5, 2024 •
edited
Loading

Coverage Status

coverage: 82.552%. remained the same
when pulling 96d5ead on t-mialve:t-mialve/update-owners
into 7c93e26 on kubernetes-sigs:main.

@t-mialve t-mialve force-pushed the t-mialve/update-owners branch from 302f6e0 to 96d5ead Compare September 5, 2024 13:41
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Sep 5, 2024
dabradley
dabradley approved these changes Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@dabradley dabradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dabradley, t-mialve

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2024
@k8s-ci-robot k8s-ci-robot merged commit 42e338b into kubernetes-sigs:main Sep 5, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dabradley dabradley dabradley approved these changes

@vinli-cn vinli-cn Awaiting requested review from vinli-cn

Assignees

@dabradley dabradley

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@t-mialve @coveralls @k8s-ci-robot @dabradley