-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken links to testgrid dashboard #147
Fix broken links to testgrid dashboard #147
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AdityaVardhanSingh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @AdityaVardhanSingh! |
Hi @AdityaVardhanSingh. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hey, can you guys review this? |
Don't modify release-tools in downstream repos like this one. First csi-release-tools needs to be fixed (done in kubernetes-csi/csi-release-tools@1f7e605), then an automatic sync will copy that to the other repos. |
@pohly which repo needs to be fixed next? |
Please don't fix any further repos which have a "release-tools" directory. |
Ok, thanks for clarifying @pohly , actually I am new to open source and didn't know much about upstream and downstream repos but thanks to you, your mention made me aware of it. |
release-note
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
The domain name of the testgrid dashboard was updated from k8s-testgrid.appspot.com to testgrid.k8s.io. After the update old domain now throws a 'page not found error'. So fixes the broken links of the testgrid dashboard.
Which issue(s) this PR fixes:
This is related to an umbrella issue and fixes a task of the same: kubernetes/test-infra#30370