Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links to testgrid dashboard #147

Conversation

AdityaVardhanSingh
Copy link

@AdityaVardhanSingh AdityaVardhanSingh commented Aug 26, 2023

release-note
What type of PR is this?
/kind cleanup

What this PR does / why we need it:
The domain name of the testgrid dashboard was updated from k8s-testgrid.appspot.com to testgrid.k8s.io. After the update old domain now throws a 'page not found error'. So fixes the broken links of the testgrid dashboard.

Which issue(s) this PR fixes:
This is related to an umbrella issue and fixes a task of the same: kubernetes/test-infra#30370

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Aug 26, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 26, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: AdityaVardhanSingh / name: Aditya Singh (3aa2f01)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 26, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AdityaVardhanSingh
Once this PR has been reviewed and has the lgtm label, please assign xing-yang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Welcome @AdityaVardhanSingh!

It looks like this is your first PR to kubernetes-csi/csi-lib-utils 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/csi-lib-utils has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 26, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @AdityaVardhanSingh. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 26, 2023
@AdityaVardhanSingh AdityaVardhanSingh changed the title Fixed broken links to testgrid dashboard Fixes broken links to testgrid dashboard Aug 31, 2023
@k8s-ci-robot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 31, 2023
@AdityaVardhanSingh
Copy link
Author

Hey, can you guys review this?

@AdityaVardhanSingh AdityaVardhanSingh changed the title Fixes broken links to testgrid dashboard Fix broken links to testgrid dashboard Aug 31, 2023
@pohly
Copy link
Contributor

pohly commented Sep 1, 2023

Don't modify release-tools in downstream repos like this one.

First csi-release-tools needs to be fixed (done in kubernetes-csi/csi-release-tools@1f7e605), then an automatic sync will copy that to the other repos.

@pohly pohly closed this Sep 1, 2023
@AdityaVardhanSingh
Copy link
Author

@pohly which repo needs to be fixed next?

@pohly
Copy link
Contributor

pohly commented Sep 1, 2023

Please don't fix any further repos which have a "release-tools" directory.

@AdityaVardhanSingh
Copy link
Author

Ok, thanks for clarifying @pohly , actually I am new to open source and didn't know much about upstream and downstream repos but thanks to you, your mention made me aware of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants