Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding HTTP2 transport settings in util/httpclient #396

Merged

Conversation

julienstroheker
Copy link
Contributor

Related to #395

This pull request introduces a new feature to enable HTTP2 client ping with configurable timeouts via environment variables. The changes include updates to the HTTP client initialization and the addition of new tests to ensure the feature works as expected.

Using the 3 following env variables :

HTTP2_TRANSPORT_PING_ENABLED           // bool
HTTP2_TRANSPORT_READ_IDLE_TIMEOUT      // time.Duration
HTTP2_TRANSPORT_PING_TIMEOUT           // time.Duration

HTTP Client Enhancements:

  • Added support for HTTP2 client ping with configurable read idle timeout and ping timeout via environment variables in util/httpclient/utils.go.
  • Modified the HTTP client initialization to set up HTTP2 ping if the corresponding environment variable is enabled.

Testing:

  • Added comprehensive tests in util/httpclient/utils_test.go to verify the HTTP2 client ping functionality and default HTTP client properties.

@julienstroheker julienstroheker requested a review from a team as a code owner October 16, 2024 21:28
@julienstroheker julienstroheker force-pushed the juliens/http2clienttransport branch from 07a9726 to 11a9955 Compare October 16, 2024 21:32
Signed-off-by: Julien Stroheker <[email protected]>
Copy link
Contributor

@bcho bcho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tamalsaha tamalsaha added the automerge Kodiak will auto merge PRs that have this label label Oct 16, 2024
Copy link
Contributor

@weinong weinong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@kodiakhq kodiakhq bot merged commit 85662d2 into kubeguard:master Oct 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Kodiak will auto merge PRs that have this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants