Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add securitycontext for PSS PoC (rootless Kubeflow) #2939

Merged
merged 5 commits into from
Jan 20, 2025
Merged

chore: Add securitycontext for PSS PoC (rootless Kubeflow) #2939

merged 5 commits into from
Jan 20, 2025

Conversation

biswassri
Copy link
Contributor

@biswassri biswassri commented Dec 20, 2024 •
edited
Loading

Pull Request Template for Kubeflow manifests Issues

✏️ A brief description of the changes

I changed ...

Adding PSS enforceable for sso and oauth2-proxy and enjoy a rootless Kubeflow #2528

📦 List any dependencies that are required for this change

My PR depends on #

🐛 If this PR is related to an issue, please put the link to the issue here.

The following issues are related, because ...

✅ Contributor checklist

You can join the CNCF Slack and access our meetings at the Kubeflow Community website. Our channel on the CNCF Slack is here #kubeflow-platform.

juliusvonkohout
juliusvonkohout reviewed Dec 20, 2024
View reviewed changes
apps/pipeline/upstream/third-party/argo/upstream/manifests/quick-start/sso/dex/dex-deploy.yaml Outdated
Copy link
Member

@juliusvonkohout juliusvonkohout Dec 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an upstream file. Please do not modify it, but instead our DEX at https://github.com/kubeflow/manifests/tree/master/common/dex

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! I'll update this.

@juliusvonkohout
Copy link
Member

juliusvonkohout commented Dec 21, 2024 •
edited
Loading

We also need to remove the two patches from /contrib/security then if we apply them always.

@juliusvonkohout juliusvonkohout self-assigned this Jan 9, 2025
@google-oss-prow google-oss-prow bot added size/M and removed size/S labels Jan 9, 2025
@biswassri
Copy link
Contributor Author

We also need to remove the two patches from /contrib/security then if we apply them always.

@juliusvonkohout removed the dex and oauth yaml files from /contrib/security let me know if there are any other changes required.

@juliusvonkohout
Copy link
Member

/ok-to-test

@biswassri
Copy link
Contributor Author

@juliusvonkohout Are we good with the above changes? If so I think we can go ahead and merge this ?

@juliusvonkohout
Copy link
Member

Thank you very much

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Jan 20, 2025
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 26dadec into kubeflow:master Jan 20, 2025
13 checks passed
@biswassri biswassri deleted the PSS-patch branch January 20, 2025 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusvonkohout juliusvonkohout juliusvonkohout left review comments

@gkcalat gkcalat Awaiting requested review from gkcalat

Assignees

@juliusvonkohout juliusvonkohout

Labels
approved lgtm ok-to-test size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@biswassri @juliusvonkohout