Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust code structure and remove useless code #126

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

wbc6080
Copy link
Collaborator

@wbc6080 wbc6080 commented Jan 27, 2024

  1. Remove the code that originally generated the mapper project. Now the mapper project generated by the user should be in the mapper-framework repo.

  2. The original built-in mapper project is still retained in this warehouse and stored in the mappers directory. Move the original pkg and config directories to the mappers directory,making the mappers-go repository clearer in code structure.

Signed-off-by: wbc6080 <[email protected]>
@wbc6080 wbc6080 closed this Jan 27, 2024
@wbc6080 wbc6080 reopened this Jan 27, 2024
@wbc6080 wbc6080 closed this Jan 29, 2024
@wbc6080 wbc6080 reopened this Jan 29, 2024
@wbc6080 wbc6080 closed this Jan 30, 2024
@wbc6080 wbc6080 reopened this Jan 30, 2024
@kubeedge-bot kubeedge-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 30, 2024
@luomengY
Copy link
Member

/lgtm
tks

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2024
Copy link
Member

@fisherxu fisherxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fisherxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 13, 2024
@kubeedge-bot kubeedge-bot merged commit ab4f8b9 into kubeedge:main Jun 13, 2024
6 checks passed
@luomengY luomengY removed their assignment Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants