promoted git-sync-annotation to spec field #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonCqk
reviewed
Apr 3, 2023
* validate helm chart job added Signed-off-by: Basit Hasan <[email protected]> * minor fix Signed-off-by: Basit Hasan <[email protected]> * add version in values.yaml Signed-off-by: Basit Hasan <[email protected]> --------- Signed-off-by: Basit Hasan <[email protected]>
Signed-off-by: Basit Hasan <[email protected]>
Signed-off-by: Basit Hasan <[email protected]>
Signed-off-by: Basit Hasan <[email protected]>
Signed-off-by: Basit Hasan <[email protected]>
basit9958
force-pushed
the
Promote-git-sync-feature-as-the-spec-field
branch
from
be56b59
to
17be123
Compare
|
cc @SimonCqk ci and e2e are failing because workflow runner is not picking the job. I have opened a pr to fix that please merge and re trigger the workflow here |
Signed-off-by: Basit Hasan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
It promotes git-sync annotation to the spec field
II. Does this pull request fix one issue?
fixes #262