Add support for UTF-16 encoded kubeconfig files #1654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: goenning <[email protected]>
clux
reviewed
Dec 5, 2024
| fn read_path<P: AsRef<Path>>(path: P) -> io::Result<String> { | ||
| let bytes = fs::read(&path)?; | ||
| match bytes.as_slice() { | ||
| [0xFF, 0xFE, ..] => { |
There was a problem hiding this comment.
a comment for these magic numbers would be helpful for a future person 😅
There was a problem hiding this comment.
would you prefer using encoding_rs crate instead?
There was a problem hiding this comment.
Perhaps also putting a comment to use String::from_utf16le and friends when they become stable
Signed-off-by: goenning <[email protected]>
|
Test added |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1654 +/- ##
=======================================
+ Coverage 75.6% 75.6% +0.1%
=======================================
Files 82 82
Lines 7405 7430 +25
=======================================
+ Hits 5591 5611 +20
- Misses 1814 1819 +5
|
clux
approved these changes
Dec 6, 2024
Danil-Grigorev
pushed a commit
to Danil-Grigorev/kube
that referenced
this pull request
Dec 18, 2024
* support for utf16 files Signed-off-by: goenning <[email protected]> * add test cases for utf16 Signed-off-by: goenning <[email protected]> --------- Signed-off-by: goenning <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Windows PowerShell uses the Unicode UTF-16LE encoding by default, which means that kubeconfig files may be encoded as UTF16 if they're being generated by Windows PS.
kubectl can parse UTF16 kubeconfig files, so I thought we could add this directly into kube-rs
Solution
This PR basically adds support for UTF-16LE, UTF-16BE, UTF-8 with BOM and UTF-8