Added zip_entry_noallocreadwithoffset #359
Conversation
src/zip.c
Outdated
| return (ssize_t)ZIP_ENORITER; | ||
| } | ||
|
|
||
| mz_uint8 tmpbuf[ZIP_DEFAULT_ITER_BUF_SIZE]; |
There was a problem hiding this comment.
Added a define for users to control their stack usage.
src/zip.h
Outdated
| /** | ||
| * Default zip iterator stack size (in bytes) | ||
| */ | ||
| #define ZIP_DEFAULT_ITER_BUF_SIZE 32*1024 |
There was a problem hiding this comment.
What's a good default size?
src/zip.c
Outdated
| read_size = to_read; | ||
| MZ_ASSERT(read_size <= tmpbuf_size); | ||
|
|
||
| memcpy(&((mz_uint8*)buf)[write_cursor], &tmpbuf[read_cursor], read_size); |
There was a problem hiding this comment.
Do we really need this tmpbuf, and memcpy here?
mz_zip_reader_extract_iter_read already calls memcpy. Maybe we can optimize it a litle bit, if we can get rid of tmpbuf.
There was a problem hiding this comment.
Well, the question is, where should mz_zip_reader_extract_iter_read() copy to?
Perhaps you meant that the caller also provides the tempbuffer?
Something like:
ssize_t zip_entry_noallocread_offset(struct zip_t *zip,
size_t offset, size_t size, void *buf,
size_t tmpbufsize, void *tmpbuf)There was a problem hiding this comment.
I get what you mean now.
I think it should be possible.
It will likely still need a memmove, to put any "unaligned" bytes from the middle of the buffer, into the start of the buffer.
src/zip.h
Outdated
| * @return the return code - the number of bytes actually read on success. | ||
| * Otherwise a negative number (< 0) on error (e.g. offset is too large). | ||
| */ | ||
| extern ZIP_EXPORT ssize_t zip_entry_noallocread_offset(struct zip_t *zip, |
There was a problem hiding this comment.
Maybe to follow similar API, we can name it zip_entry_noallocreadwithoffset. I know it's not the prettiest name, but at least it's consistent with other API ...witherror, ...withindex, etc.
JCash
changed the title
|
Thanks, could you just reformat a code by running: |
The new function
zip_entry_noallocread_offset()will allow us to stream content from a zip file.I know there was no discussion beforehand, so consider this as a draft and discussion material.