Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix permissions to work with unzip #350

Merged
merged 1 commit into from
Jun 29, 2024
Merged

Fix permissions to work with unzip #350

merged 1 commit into from
Jun 29, 2024

Conversation

7c00
Copy link
Contributor

@7c00 7c00 commented Jun 29, 2024

The version-made-by field was not set when creating an archive. When the archive is extracted by unzip in Linux and macOS, the origin file permissions (especially executable perms) are lost.

This patch adds the missing field.

@kuba--
Copy link
Owner

kuba-- commented Jun 29, 2024

@7c00 - thanks for the PR. I suggest PR this change directly to miniz. It will be easier to upgrade miniz as dependency (with less changes to propagate).

@7c00
Copy link
Contributor Author

7c00 commented Jun 29, 2024

@kuba-- Fine. Is richgel999/miniz the upstream we depend on?

@kuba--
Copy link
Owner

kuba-- commented Jun 29, 2024

@kuba-- Fine. Is richgel999/miniz the upstream we depend on?

Yes, that's the repo.
Thanks.

@kuba-- kuba-- closed this Jun 29, 2024
@kuba-- kuba-- reopened this Jun 29, 2024
@kuba--
Copy link
Owner

kuba-- commented Jun 29, 2024

Actually, I think the change is so small so we can merge it, anyway without waiting for miniz (I hope they will merge it soon).

@kuba-- kuba-- merged commit 1682607 into kuba--:master Jun 29, 2024
8 checks passed
@7c00 7c00 deleted the fix-unzip branch June 30, 2024 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants