Support zip archives not starting at zero offset #346
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zip archives are usually read from the back to the front, making it possible to append them to other files (e.g. executables) in order to provide some kind of embedded filesystem.
This PR makes it possible to read, write, and update such zip files without affecting the existing functionality.
What's not possible is to append an archive to an arbitrary non-zip file.
The
w
switch should be able to do so, but at the moment the documentation states'w': creates an empty file for writing.
without rewinding the stream. I'd amend the documentation and make that mode create a brand new zip archive using the stream cursor as starting offset.Would that be ok?
Once the
w
issue is sorted some tests can be easily written.