Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add odin binding link #315

Merged
merged 2 commits into from
Oct 19, 2023
Merged

add odin binding link #315

merged 2 commits into from
Oct 19, 2023

Conversation

thechampagne
Copy link
Contributor

No description provided.

@kuba--
Copy link
Owner

kuba-- commented Oct 15, 2023

If you have just one binding, why not to put the link next to the Odin snippet as (with note: third party implementation)

@thechampagne
Copy link
Contributor Author

I wrote more after I opened the pull request.

@kuba--
Copy link
Owner

kuba-- commented Oct 15, 2023

If you have more than 3 we can think about special table/section. Right now, I think it makes sense to add an extra link per snippet.

@thechampagne
Copy link
Contributor Author

Should I change the snippet to use the binding instead of manually writing C functions ?

@kuba--
Copy link
Owner

kuba-- commented Oct 16, 2023

Should I change the snippet to use the binding instead of manually writing C functions ?

It's up to you, but IMO it makes sense to just keep snippets and/or links close to each other (for consistency)

@thechampagne thechampagne changed the title add bindings list add odin binding link Oct 16, 2023
@kuba-- kuba-- merged commit dcec4b9 into kuba--:master Oct 19, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants