Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate escape #204

Merged
merged 5 commits into from
Feb 8, 2024
Merged

Eliminate escape #204

merged 5 commits into from
Feb 8, 2024

Conversation

nobu-g
Copy link
Member

@nobu-g nobu-g commented Feb 5, 2024

What

Remove the escape of hydra variable interpolation ${hoge}.

@nobu-g nobu-g requested a review from omukazu February 5, 2024 08:25
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (bdb34b7) 91.25% compared to head (a3cb37c) 91.40%.

Files Patch % Lines
src/kwja/datamodule/datasets/typo_inference.py 88.88% 1 Missing ⚠️
src/kwja/datamodule/datasets/utils.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #204      +/-   ##
==========================================
+ Coverage   91.25%   91.40%   +0.14%     
==========================================
  Files          59       59              
  Lines        4998     5014      +16     
==========================================
+ Hits         4561     4583      +22     
+ Misses        437      431       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@omukazu omukazu merged commit f9d5779 into dev Feb 8, 2024
56 of 66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants