Improve ktor-client request/response logging #1728
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dragneelfps |
|
Just wondering if will affect logging error responses if not changed to |
e5l
reviewed
Mar 17, 2020
| @@ -24,12 +24,13 @@ import kotlinx.coroutines.* | |||
| class Logging( | |||
| val logger: Logger, | |||
| var level: LogLevel, | |||
| var filters: List<(HttpRequestBuilder) -> Boolean> | |||
| val filters: List<(HttpClientCall) -> Boolean>, | |||
There was a problem hiding this comment.
I'm not sure if it's ok to replace the request builder with the call here. The call will be created only after the network request, but we should print the request log before any network activity.
Could you tell me if you have an idea of fixing this?
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
e5l
force-pushed
the
main
branch
2 times, most recently
from
d084312
to
1ae2c1f
Compare
|
Closing this PR as stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1727