Fix django templates error when getting static files from Google Cloud Storage bucket #24
+1
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
django-storages
by default always generates a signed url for downloading data from cloud storage bucket. That's why it threw an error when trying to get static files for/admin
route. The solution is to telldjango-storages
that default ACL is "publicRead" (since the static files bucket is public), because we don't need to use a signed url. File upload is not affected by this change (upload worked correctly before and still works).For more context you can read this issue on django-storages repo and the part about
GS_DEFAULT_ACL
variable from the django-storages docs.