review suggestions

Signed-off-by: Spolti <[email protected]>

Dockerfile

@@ -91,6 +91,8 @@ RUN true \
 COPY .pre-commit-config.yaml ./
 RUN git init && \
     pre-commit install-hooks && \
+    # Fix: 'fatal: detected dubious ownership in repository'
+    RUN git config --global --add safe.directory "*" && \
     rm -rf .git
 
 # Download dependencies before copying the source so they will be cached

Makefile

@@ -51,7 +51,7 @@ run: use.develop
 
 .PHONY: test
 ## Run tests
-test: fmt
+test:
 	./scripts/run_tests.sh
 
 .PHONY: fmt

model-mesh-ovms-adapter/server/modelmanager.go

@@ -259,9 +259,8 @@ type request struct {
 	c   chan<- error
 }
 
-// Run loop for the manager's internal actor that owns the model repository config
-//
-// # Maintains a slice of batched requests that are in process in the reload
+// run loop for the manager's internal actor that owns the model repository config
+// Maintains a slice of batched requests that are in process in the reload
 //
 // Returns results from the reload operation once it completes
 // Receives a stream of requests from its channel

scripts/fmt.sh

@@ -15,9 +15,9 @@
 
 # Fix: 'fatal: detected dubious ownership in repository',
 # only do this if it is running into the develop image
-if [ "${PWD}" == "/opt/app" ]; then
-  git config --global --add safe.directory "*"
-fi
+#if [ "${PWD}" == "/opt/app" ]; then
+#  git config --global --add safe.directory "*"
+#fi
 
 pre-commit run --all-files
 RETURN_CODE=$?