Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added GitHub Workflow For Issues And Pull Requests #29

Merged
merged 6 commits into from
Feb 1, 2024
Merged

feat: Added GitHub Workflow For Issues And Pull Requests #29

merged 6 commits into from
Feb 1, 2024

Conversation

JiyaGupta-cs
Copy link
Contributor

Closes #28

@JiyaGupta-cs
Copy link
Contributor Author

@ksauraj Please review the PR

@ksauraj
Copy link
Owner

ksauraj commented Jan 30, 2024

@ksauraj Please review the PR

Yah I'm reviewing it now.

@ksauraj
Copy link
Owner

ksauraj commented Jan 31, 2024

@JiyaGupta-cs do those quick changes, and ig this will be ready to get merged.

@JiyaGupta-cs
Copy link
Contributor Author

@ksauraj Which changes ?

@JiyaGupta-cs
Copy link
Contributor Author

@ksauraj Which changes are you referring to? You haven't told me earlier

@ksauraj
Copy link
Owner

ksauraj commented Jan 31, 2024

@ksauraj Which changes are you referring to? You haven't told me earlier

image
These changes, check those review which i gave.

@JiyaGupta-cs
Copy link
Contributor Author

@ksauraj Done! Please review

ksauraj
ksauraj reviewed Jan 31, 2024
View reviewed changes
Copy link
Owner

@ksauraj ksauraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I just wanted you to remove

- label: "I have starred the repository"
          required: true

.github/workflows/ISSUE_TEMPLATE/bug.yml Outdated
attributes:
label: "Checklist"
options:
- label: "I have starred the repository"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is a necessary checklist. If possible remove it.

.github/workflows/ISSUE_TEMPLATE/feature_request.yml Outdated
attributes:
label: "Checklist"
options:
- label: "I have starred the repository"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here...

.github/workflows/ISSUE_TEMPLATE/bug.yml Outdated
@@ -0,0 +1,53 @@
name: ​🐞 Bug
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing that icon is preferable.

@ksauraj
Copy link
Owner

ksauraj commented Jan 31, 2024

Actually I just wanted you to remove

- label: "I have starred the repository"
          required: true

If you can fix this or else I'm ready to merge this too.

@JiyaGupta-cs
Copy link
Contributor Author

@ksauraj Fixed!!!

@ksauraj
Copy link
Owner

ksauraj commented Feb 1, 2024

Great job, @JiyaGupta-cs , and thank you for being patient.

@ksauraj ksauraj added IWOC2024 approved ✅ PR approved by maintainer. labels Feb 1, 2024
@JiyaGupta-cs
Copy link
Contributor Author

JiyaGupta-cs commented Feb 1, 2024 •
edited
Loading

Great job, @JiyaGupta-cs , and thank you for being patient.

Could you please change the label to hard ? If you like it

@ksauraj ksauraj merged commit 5f67f08 into ksauraj:master Feb 1, 2024
1 check passed
@ksauraj
Copy link
Owner

ksauraj commented Feb 2, 2024

Could you please change the label to hard ? If you like it

I already merged it, won't count now anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksauraj ksauraj ksauraj left review comments

Assignees
No one assigned
Labels
approved ✅ PR approved by maintainer. IWOC2024
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat: Adding GitHub workflows for issue and pull request
2 participants
@JiyaGupta-cs @ksauraj