Kotlinize inherited tests #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krzema12
force-pushed
the
kotlinize-inherited-tests
branch
from
76f971a to
216e8ef
Compare
OptimumCode
previously approved these changes
Jan 15, 2025
There was a problem hiding this comment.
Hi, @krzema12. I did not really check that the Kotlin content is the same as Java content - I will do it a bit later...
I left a few comments related to try-with-resources - there are a few places where it can be added
src/jvmTest/java/it/krzeminski/snakeyaml/engine/kmp/usecases/inherited/InheritedImportUtils.kt
Outdated
Show resolved
Hide resolved
src/jvmTest/java/it/krzeminski/snakeyaml/engine/kmp/usecases/inherited/InheritedImportUtils.kt
Outdated
Show resolved
Hide resolved
src/jvmTest/java/it/krzeminski/snakeyaml/engine/kmp/usecases/inherited/InheritedReaderTest.kt
Outdated
Show resolved
Hide resolved
src/jvmTest/java/it/krzeminski/snakeyaml/engine/kmp/usecases/inherited/InheritedTokensTest.kt
Outdated
Show resolved
Hide resolved
src/jvmTest/java/it/krzeminski/snakeyaml/engine/kmp/usecases/inherited/InheritedTokensTest.kt
Outdated
Show resolved
Hide resolved
OptimumCode
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #269.
Focuses just on porting a group of related tests (with a common parent class) to Kotlin, for now JVM-specific. Commonization will be done in a separate change.